Styling adjustment on header for certain pages (Fixes #15873) #16027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maureenlholland
added
Needs Review
janbrasna
reviewed
Mar 14, 2025
Comment on lines
+167
to
+171
| a { | ||
| &:hover { | ||
| color: $color-black !important; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just quickly looking at the impact: (not diving into formatting and linting as this would fail the checks, starting with important not being allowed generally etc.…)
- It's not always black, current item uses dark green so there are perhaps more combinations to check for.
- I might have missed the idea why this is only applied in the js enhanced block, and not universally?
- There are existing specificity overrides, so this might be worth exploring if such nesting helps with the order:
bedrock/media/css/m24/components/navigation-refresh.scss
Lines 368 to 373 in b57052f
|
Closed in favor of #16147 |
|
@lbrooks81 Thanks for the changeset, it helped tracking down the actual missing anchor in the specificity — but eventually needed a slightly different approach to fit in — but thanks to this contribution things started moving to getting it fixed, so the effort put into the PR is appreciated. 🎩 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
Added styling to fix brief flash of color upon hovering over navigation items
Significant changes and points to review
Issue / Bugzilla link
#15873
Testing
http://localhost:8000/fr/firefox/challenge-the-default/
http://localhost:8000/en/firefox/family/